Conversation
vscode/webview/plan/styles.css - Remove global equal-width flex rules from .widget-button - Add scoped rule .widget-buttons .widget-button for action-row equal-width sizing - Add intrinsic width rules (flex: 0 0 auto; min-width: auto) to .terminal-stop-button vscode/webview/plan/styles.md - Document that .widget-button provides shared visual style only - Document that equal-width behavior applies only in .widget-buttons context - Document that .terminal-stop-button uses intrinsic width with right alignment vscode/test/playwright/test-session-append.js - Add hard regression assertion comparing terminal stop button width vs action-row button width - Throws error if stop button is not narrower than action buttons vscode/test/playwright/test-session-append.md - Document the hard assertion for stop-width regression check Issue 966 resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[bugfix][#966] Compact Stop Button Width in Plan Webview
Summary
Fixes the visually over-wide terminal
Stopbutton in the Plan webview by removing unintended inherited equal-width flex behavior.Changes
CSS Fix (vscode/webview/plan/styles.css)
.widget-button.widget-buttons .widget-buttonfor action-row equal-width sizingflex: 0 0 auto; min-width: auto) to.terminal-stop-buttonDocumentation Updates
.widget-buttonprovides shared visual style only; equal-width behavior applies only in.widget-buttonscontext;.terminal-stop-buttonuses intrinsic widthTest Update
Verification
make vscode-pluginsucceeds)Stopbutton is now content-sized (not stretched).widget-buttonsremain equal-widthcloses #966
Issue 966 resolved